I thought this mod was broken again with ammo not showing up, but then i removed a mod and it came back. So if you have the Lock apparel mod it will cancel out the ammo icon for it's own.

Currently everything is quite stressful, but next month maybe, since I will have some time off to spend, I will hopefully find some time to look into developing the merged version again in that case.

In case I finish and release it, I will inform you.

@Syrus Regarding the 1.6 update, my workflow is not specific as I just let the script choose the next mod to work on. During that time I dont really have the time to do much else.
I have no problem with anyone taking over the mod, I have no personal interest in it. Ive let other mods go to more invested modders before so no problem there. If you release a version Ill just point to yours and deprecate this.

@Mlie
To correct what I stated rearlier, I was mistaken about "Game.FinalizeInit", that is called after the world is loaded. "LongEventHandler.ExecuteWhenFinished" is a substitute for DefsLoaded apparently

Anyway, I used it to call ApplyDefPatches and it works for what I wanted

In regard to the control of how the mod works:
When 1.6 was released I suggested to take over the development of Yayo's Combat, merging the Addon into it. Would have reduced your workload, but as this mod was updated the day after I announced that intention, I considered that there was no interest for it, so I stopped developing the integrated version and stuck with modifying it via Harmony.

@Syrus I wasnt really involved in the removal of HugsLib, it was added by a PR. That route is open to you too as the repo is public, if you want even more control of how this mod works.

Ok, letting me determine when to run the patches should work.

You could've just reimplemented the way HugsLib handled "DefsLoaded" though, applying the patches once Defs initialization is done on game start, instead of on loading into the world.

Guess that is how I will use the method in the addon then. I'll look into it tomorrow though, I'm too tired for it now

@Syrus Well the patch method is public so you could just call it when needed to be sure theyve been applied. It will never run more than once so feel free to trigger it so it works in your code.

That's what I do, problem is, to create the settings I need to know which weapons use ammo (and which ammo). If the ammo is patched to them only after loading into the world, it means the settings cannot be opened (or changed) before that point

@Syrus Perhaps you can just postfix the patch-applier method?

Yes, it now applies the patches to the defs properly and only once, but this way prevents my addon mod from modifying the ammo types of weapons if one has not yet loaded the game world once

@Syrus Strange, perhaps it has to do with load order as it worked when I tested it.
Ive moved it later in the process now, hopefully it will work better for you now.

Was trying to make the addon mod work with the latest change and I'm pretty sure that ApplyDefPatches being called in the static constructor is too early: at that point the Defs are not yet loaded.
To checkk it, I added a debug print to the method and "DefDatabase<ThingDef>.AllDefs" is empty, so the Def patches are not actually applied (but there is also no error, as it just does nothing)

The reload widgets should stop multiplying now
Thanks for the detailed report Syrus!

With the change to remove HugsLib, "YayoCombatCore.ApplyDefPatches" is now called once you load into a map, instead of after the game has loaded the defs, as was previously the case with "DefsLoaded" (from HugsLib).

For reasons unknown to me, the method is also called twice when loading into a map. I have never worked with the "WorldComponent", no idea why it is created twice.

This causes issues with my Yayo's Combat AddOn mod, preventing changing the AmmoDefs, as well as likely also causing the Reloadable-CompProperty to be applied twice (what @Gen_Goldo mentioned).

I suggest executing that method only once, after the game has started and once all Defs have been loaded, iIrc I used "Game.FinalizeInit" for that in another mod.

Weapons have multiple ammo chargers, have a bow that had this five times, shows in weapon desc and in UI: example

Long bow
Remaining Charges 21 / 21
Remaining Charges 21 / 21
Remaining Charges 21 / 21
Remaining Charges 21 / 21
Remaining Charges 21 / 21

Looks like everytime you load a save, it adds an extra line to the description

Bug after the update there's 2 stats for the ammo counter and ammo type in the description.

It would appear all is well after latest update I fought a mech cluster and only lost an eye and a nose and didn't have to dev build 100 turrets to kill 5 mechs.

Some wierdness I noticed is multiple ammo counts in the UI when examining a weapon, and when selecting raiders

Disregard, it seems fixed. Must have been a one time thing, or workshop update wierdness

@Pazik I dont know what a janky ui is

Ammo is now working, but the UI is a little janky. Is this a bug or a mod conflict?

I always appreciate your kindness.

Thanks for the update, my fighters got knocked up so I gotta wait till the little beans pop out before trying War Queen again. Fingers crossed I can make a dent in their armor :D

The settings should now be applied correctly on game-start, sorry about that

@CentiSully "Yayos Combat 3 - Addon" mod was doing it for me, take off that mod and it works fine

2 Scythers and ~8 Urchins destroyed >50 turrets and all the shots are glancing off of them feels like I never ditched CE :D

https://steamcommunity.yuanyoumao.com/sharedfiles/filedetails/?id=3608508970

To get the previous working version, go here and download v1.6.3 , then extract it to your rimworld mods folder.

https://github.com/emipa606/YayosCombat3/releases?q=1.6.3&expanded=true

Afterwards just make sure that version is enabled in your modlist. Then be sure to reenable ammo (which requires a restart after enabling).

After the update Yayo Combat isn't active anymore even with it turned on in the options. I have restarted the game a bunch of times but it remains off the little bullet ammo icon is not there. I got it working once after a bunch of restarts but then after coming back later it is off again.

Assign tab doesn't show for me now. Also UI for ammo isn't visible anymore.

First of all thanks for no hugs! Last mod that required it.

Is there something going on with mechanoids after the update though? Before the no-hugs I killed Diabolus with my current squad/weapons more or less effortlessly. I summoned War Queen right after updating and removing hugs and I literally can't make a dent in either the scythers or pikemen, nor the little urchins. I built 100 uranium slug and sentry turrets in dev mode, they barely killed few pikemen before the urchins and scythers mowed them down.

Or it's more like the accuracy is off, all combat logs are like this 99.99% shots on the mechanoids missing https://pastebin.com/hQ2B1QsW

Fantastic

No HUGSLIB! YEAH THANK YOU!!!!!!!

I don't see the ammo anymore? And I did re-enable in options and restart the game

Now that's pretty damn huge.

OMG thank you you sweet sweet legends Hugslib was the mod giving me so much headache with errors breaking my UI and god knows what else.

Thanks to Zaljerem, this mod no longer needs HugsLib! All settings should transfer over to the new system but you may need to restart the game one extra time if you were using the ammo-system

@explodoboy Please see the Reporting Issues section described above

This mod appears to have a compatibility issue with Only If 'Tolerance' Below in Drug Policy . When both mods are active, YC3 appears to fail to load.

@Mlie Thanks for the quick response on it! Totally understand not having the time, thanks for the answer~

@Tika Not without a full rewrite of the mod-settings, something I do not really have time to do at the moment.

Is there anyway to get away from the HugLib requirement for this mod? I adore the changes this makes, but am trying to remove Hugs from my load order entirely.

anyone knows specific algorithm of armor? It confused me a lot, 40% penetration weapon could deal complete damage against 140% armor mechnoids

@rhyndo I see, havent tried those

@Mlie yayo had some old tutorials on how to add your own ammos to weapons, on this github page: https://github.com/rimworldYayo/Yayo-s-Combat/wiki/Custom-Ammo-Setting-Tut

@PARSA TV Should be fixed now

Downed/dead raiders don't drop anything anymore after Odyssey update. I can't find a mod option to control this.

@rhyndo What custom ammo?

does custom ammo still work?

Downed/dead raiders don't drop any ammo anymore after Odyssey update, even though they had ammo before downed. I can't find a mod option to control this. Is this a bug?

I LOVE THIS MOD SO MUCH